Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]Fix flake hostport e2e testing #3961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP]Fix flake hostport e2e testing #3961

wants to merge 1 commit into from
+1 −0

Conversation

JesseStutler
Copy link
Member

What type of PR is this?

/kind flake
/area test

What this PR does / why we need it:

The e2e testing called HostPort always failed, blocking us to merge some PRs

Which issue(s) this PR fixes:

Fixes #3918

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@volcano-sh-bot volcano-sh-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/flake Categorizes issue or PR as related to a flaky test. labels Jan 9, 2025
@volcano-sh-bot volcano-sh-bot added area/test CI and test related Issues or PRs kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 9, 2025
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign monokaix
You can assign the PR to them by writing /assign @monokaix in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. area/scheduling area/controllers area/cli area/dependency Issues or PRs related to dependency changes area/webhooks area/deploy Issues or PRs related to deploy/helm/build/scripts changes area/documentation documentation of design or user-guide area/performance Issues or PRs related to performance size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2025
@JesseStutler
Copy link
Member Author

JesseStutler commented Jan 9, 2025 •
edited
Loading

/remove-area cli
/remove-area scheduling
/remove-area controllers
/remove-area dependency
/remove-area webhooks
/remove-area deploy
/remove-area documentation
/remove-area performance
/remove-kind documentation
/remove-kind feature
/remove-kind failing-test
/remove-kind cleanup
/remove-kind bug

@volcano-sh-bot volcano-sh-bot removed area/cli area/scheduling area/controllers area/dependency Issues or PRs related to dependency changes area/webhooks area/deploy Issues or PRs related to deploy/helm/build/scripts changes area/documentation documentation of design or user-guide area/performance Issues or PRs related to performance kind/documentation Categorizes issue or PR as related to documentation. labels Jan 9, 2025
@volcano-sh-bot volcano-sh-bot removed kind/feature Categorizes issue or PR as related to a new feature. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Jan 9, 2025
@volcano-sh-bot
Copy link
Contributor

@JesseStutler: Those labels are not set on the issue: area/cli

In response to this:

/remove-area cli
/remove-area scheduling
/remove-area controllers
/remove-area dependency
/remove-area webhooks
/remove-area deploy
/remove-area documentation
/remove-area performance
/remove-kind documentation
/remove-kind feature
/remove-kind failing-test
/remote-kind clean-up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@volcano-sh-bot
Copy link
Contributor

@JesseStutler: Those labels are not set on the issue: area/cli, area/scheduling, area/controllers, area/dependency, area/webhooks, area/deploy, area/documentation, area/performance, kind/documentation, kind/feature, kind/failing-test, kind/clean-up

In response to this:

/remove-area cli
/remove-area scheduling
/remove-area controllers
/remove-area dependency
/remove-area webhooks
/remove-area deploy
/remove-area documentation
/remove-area performance
/remove-kind documentation
/remove-kind feature
/remove-kind failing-test
/remove-kind clean-up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@volcano-sh-bot volcano-sh-bot removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/bug Categorizes issue or PR as related to a bug. labels Jan 9, 2025
@volcano-sh-bot
Copy link
Contributor

@JesseStutler: Those labels are not set on the issue: area/cli, area/scheduling, area/controllers, area/dependency, area/webhooks, area/deploy, area/documentation, area/performance, kind/documentation, kind/feature, kind/failing-test

In response to this:

/remove-area cli
/remove-area scheduling
/remove-area controllers
/remove-area dependency
/remove-area webhooks
/remove-area deploy
/remove-area documentation
/remove-area performance
/remove-kind documentation
/remove-kind feature
/remove-kind failing-test
/remove-kind cleanup
/remove-kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JesseStutler
fix hostport
b7e63a4 
Signed-off-by: jessestutler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@Monokaix Monokaix Awaiting requested review from Monokaix

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/test CI and test related Issues or PRs do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/flake Categorizes issue or PR as related to a flaky test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The e2e testing Hostport in scheduling actions always fails
2 participants
@JesseStutler @volcano-sh-bot